net/net.gyp - Issue 1879743002: Expose cellular signal strength on Android to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/net.gyp

Issue 1879743002: Expose cellular signal strength on Android to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Paul's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/android/java/src/org/chromium/net/AndroidCellularSignalStrength.java ('K') | « net/android/unittest_support/AndroidManifest.xml ('k') | net/net.gypi » ('j') | net/nqe/network_quality_estimator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index db506c6e31f77fef2cca3369d4963b337fd8a321..6477ed09f9d8e6082b05f1a6bdae4ed66729a32c 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -1407,6 +1407,7 @@

'target_name': 'net_jni_headers',

'type': 'none',

'sources': [

+ 'android/java/src/org/chromium/net/AndroidCellularSignalStrength.java',

'android/java/src/org/chromium/net/AndroidCertVerifyResult.java',

'android/java/src/org/chromium/net/AndroidKeyStore.java',

'android/java/src/org/chromium/net/AndroidNetworkLibrary.java',

@@ -1444,6 +1445,7 @@

'dependencies': [

'../base/base.gyp:base',

+ 'cellular_signal_strength_error_java',

'cert_verify_status_android_java',

'certificate_mime_types_java',

'network_change_notifier_types_java',

@@ -1574,6 +1576,14 @@

'includes': [ '../build/android/java_cpp_template.gypi' ],

{

+ 'target_name': 'cellular_signal_strength_error_java',

+ 'type': 'none',

+ 'variables': {

+ 'source_file': 'android/cellular_signal_strength.cc',

+ },

+ 'includes': [ '../build/android/java_cpp_enum.gypi' ],

+ },

+ {

'target_name': 'certificate_mime_types_java',

'type': 'none',

'variables': {