Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 1879743002: Expose cellular signal strength on Android to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Paul's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 576484299f603e75492e43b431c772b5564134ca..27badd25c374f68906054c24ad74156ea5de0480 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -466,6 +466,11 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// main frame request is observed.
void RecordAccuracyAfterMainFrame(base::TimeDelta measuring_duration) const;
+ // Obtains the current cellular RSSI value and updates
bengr 2016/06/27 01:36:22 I would avoid using the term RSSI.
tbansal1 2016/06/27 19:01:17 Done.
+ // |min_signal_strength_since_connection_change_| and
+ // |max_signal_strength_since_connection_change_|.
+ void UpdateSignalStrength();
+
// Returns the effective type of the current connection based on only the
// samples observed after |start_time|. Uses HTTP RTT and downstream
// throughput to compute the effective connection type, and requires both of
@@ -594,6 +599,11 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// |effective_connection_type_recomputation_interval_| ago).
EffectiveConnectionType effective_connection_type_;
+ // Minimum and Maximum signal strength (in dbM) observed since last connection
+ // change. Updated on connection change and main frame requests.
+ int32_t min_signal_strength_since_connection_change_;
+ int32_t max_signal_strength_since_connection_change_;
+
base::ThreadChecker thread_checker_;
base::WeakPtrFactory<NetworkQualityEstimator> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698