net/android/net_jni_registrar.cc - Issue 1879743002: Expose cellular signal strength on Android to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/net_jni_registrar.cc

Issue 1879743002: Expose cellular signal strength on Android to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed pauljensen comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/android/cellular_signal_strength_unittest.cc ('K') | « net/android/java/src/org/chromium/net/AndroidCellularSignalStrength.java ('k') | net/android/unittest_support/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/android/net_jni_registrar.cc

diff --git a/net/android/net_jni_registrar.cc b/net/android/net_jni_registrar.cc

index 0a9a6be9ade485e030acd2dd4293e781cdb36b98..231ff7ce4a5306bfaad22d6c2454b15728bbeab0 100644

--- a/net/android/net_jni_registrar.cc

+++ b/net/android/net_jni_registrar.cc

@@ -6,6 +6,7 @@

#include "base/android/jni_android.h"

#include "base/android/jni_registrar.h"

+#include "net/android/cellular_signal_strength.h"

#include "net/android/gurl_utils.h"

#include "net/android/http_auth_negotiate_android.h"

#include "net/android/keystore.h"

@@ -27,6 +28,7 @@ static base::android::RegistrationMethod kNetRegisteredMethods[] = {

{"AndroidCertVerifyResult", RegisterCertVerifyResult},

{"AndroidKeyStore", RegisterKeyStore},

{"AndroidNetworkLibrary", RegisterNetworkLibrary},

+ {"AndroidCellularSignalStrength", cellular_signal_strength::Register},

pauljensen 2016/05/23 12:25:10 this looks alphabetized, can we move this up so it

tbansal1 2016/06/09 17:50:30 Done.

{"AndroidTrafficStats", traffic_stats::Register},

{"GURLUtils", RegisterGURLUtils},

{"HttpAuthNegotiateAndroid", HttpAuthNegotiateAndroid::Register},