Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: net/android/cellular_signal_strength_unittest.cc

Issue 1879743002: Expose cellular signal strength on Android to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed pauljensen comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/cellular_signal_strength_unittest.cc
diff --git a/net/android/cellular_signal_strength_unittest.cc b/net/android/cellular_signal_strength_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f2afc61c1187503e58db907e92b0263720d9cd86
--- /dev/null
+++ b/net/android/cellular_signal_strength_unittest.cc
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/android/cellular_signal_strength.h"
+
+#include <stdint.h>
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace {
+
+// This test should be run manually since the device needs to have an active
+// cellular connection.
+TEST(CellularSignalStrengthAndroidTest, DISABLED_RssiTest) {
pauljensen 2016/05/23 12:25:10 why are these tests disabled?
tbansal1 2016/06/09 17:50:30 The test device needs to have an active cellular c
+ int rssi = INT32_MIN;
+ EXPECT_TRUE(android::cellular_signal_strength::GetRssiDbm(&rssi));
+ // RSSI (in dbM) should typically be between -100 and 0.
+ EXPECT_LE(-100, rssi);
+ EXPECT_GE(0, rssi);
+}
+
+// This test should be run manually since the device needs to have an active
+// cellular connection.
+TEST(CellularSignalStrengthAndroidTest, DISABLED_SignalLevelTest) {
+ int signal_level = INT32_MIN;
+ EXPECT_TRUE(android::cellular_signal_strength::GetSignalLevel(&signal_level));
+ EXPECT_LE(0, signal_level);
+ EXPECT_GE(4, signal_level);
+}
+
+} // namespace
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698