Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Side by Side Diff: net/android/cellular_signal_strength_unittest.cc

Issue 1879743002: Expose cellular signal strength on Android to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed pauljensen comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/android/cellular_signal_strength.h"
6
7 #include <stdint.h>
8
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 namespace net {
12
13 namespace {
14
15 // This test should be run manually since the device needs to have an active
16 // cellular connection.
17 TEST(CellularSignalStrengthAndroidTest, DISABLED_RssiTest) {
pauljensen 2016/05/23 12:25:10 why are these tests disabled?
tbansal1 2016/06/09 17:50:30 The test device needs to have an active cellular c
18 int rssi = INT32_MIN;
19 EXPECT_TRUE(android::cellular_signal_strength::GetRssiDbm(&rssi));
20 // RSSI (in dbM) should typically be between -100 and 0.
21 EXPECT_LE(-100, rssi);
22 EXPECT_GE(0, rssi);
23 }
24
25 // This test should be run manually since the device needs to have an active
26 // cellular connection.
27 TEST(CellularSignalStrengthAndroidTest, DISABLED_SignalLevelTest) {
28 int signal_level = INT32_MIN;
29 EXPECT_TRUE(android::cellular_signal_strength::GetSignalLevel(&signal_level));
30 EXPECT_LE(0, signal_level);
31 EXPECT_GE(4, signal_level);
32 }
33
34 } // namespace
35
36 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698