Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1879443002: JPEG decoding: replace ownership comments with std::unique_ptr. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Marc Treib, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

JPEG decoding: replace ownership comments with std::unique_ptr. BUG=none Committed: https://crrev.com/b587f9a457ee20bfc4e3055f3b79ad7b522c8682 Cr-Commit-Position: refs/heads/master@{#386445}

Patch Set 1 #

Patch Set 2 : build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/image_encoder.h View 1 chunk +6 lines, -4 lines 0 comments Download
M components/suggestions/image_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/suggestions/image_encoder_ios.mm View 1 1 chunk +5 lines, -3 lines 0 comments Download
M printing/emf_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
4 years, 8 months ago (2016-04-11 02:48:24 UTC) #2
Marc Treib
lgtm
4 years, 8 months ago (2016-04-11 07:51:14 UTC) #3
dcheng
+thestig for //chrome and //printing
4 years, 8 months ago (2016-04-11 17:28:23 UTC) #7
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-11 18:27:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879443002/20001
4 years, 8 months ago (2016-04-11 19:45:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 19:51:34 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 19:53:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b587f9a457ee20bfc4e3055f3b79ad7b522c8682
Cr-Commit-Position: refs/heads/master@{#386445}

Powered by Google App Engine
This is Rietveld 408576698