printing/emf_win.cc - Issue 1879443002: JPEG decoding: replace ownership comments with std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/emf_win.cc

Issue 1879443002: JPEG decoding: replace ownership comments with std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/emf_win.cc

diff --git a/printing/emf_win.cc b/printing/emf_win.cc

index f00a669ccd65c68138ce7cab86f1a13f066245e1..ff1a5a5216598c067006b65c132365229f3321f5 100644

--- a/printing/emf_win.cc

+++ b/printing/emf_win.cc

@@ -366,7 +366,7 @@ bool Emf::Record::SafePlayback(Emf::EnumerationContext* context) const {

if (!DIBFormatNativelySupported(hdc, CHECKJPEGFORMAT, bits,

bmih->biSizeImage)) {

play_normally = false;

- bitmap.reset(gfx::JPEGCodec::Decode(bits, bmih->biSizeImage));

+ bitmap = gfx::JPEGCodec::Decode(bits, bmih->biSizeImage);

}

} else if (bmih->biCompression == BI_PNG) {

if (!DIBFormatNativelySupported(hdc, CHECKPNGFORMAT, bits,

« no previous file with comments | « components/suggestions/image_encoder_ios.mm ('k') | ui/gfx/codec/jpeg_codec.h » ('j') | no next file with comments »