Convert track tests from video-test.js to testharness.js based

Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/00fa6c72b82de81ab3b1cd68e9f4248eeac6b239
Cr-Commit-Position: refs/heads/master@{#388238}

[Srirama, 2016-04-13 07:18:00]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-04-13 07:20:31]

srirama.m@samsung.com changed reviewers:
+ mlamouri@chromium.org, philipj@opera.com

[Srirama, 2016-04-13 07:20:32]

PTAL.
Hope i am not eating up too much of your review time. Please let me know if you
are comfortable with number of test cases per CL, or else i will add few more
tests per CL.

[Srirama, 2016-04-13 10:29:03]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-04-13 12:37:13]

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(left):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:22:
testExpected("textTrackDisplayElement(video, 'display').innerText", "");
Removed this intentionally, because this is throwing error which is printed in
the output.

[mlamouri (slow - plz ping), 2016-04-13 13:05:00]

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(left):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:22:
testExpected("textTrackDisplayElement(video, 'display').innerText", "");
On 2016/04/13 at 12:37:12, Srirama wrote:
> Removed this intentionally, because this is throwing error which is printed in
the output.

Could you be more specific?

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(right):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:21: if
(eventCount == 2) {
I think this will allow you to save some indentation:
```
if (eventCount != 2)
  return;
```

[Srirama, 2016-04-13 13:10:03]

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(left):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:22:
testExpected("textTrackDisplayElement(video, 'display').innerText", "");
On 2016/04/13 13:05:00, Mounir Lamouri wrote:
> On 2016/04/13 at 12:37:12, Srirama wrote:
> > Removed this intentionally, because this is throwing error which is printed
in
> the output.
> 
> Could you be more specific?

When we call "textTrackDisplayElement(video, 'display')" it throws 
"No text track cue with display id '-webkit-media-text-track-display' is
currently visible" error as there is no active cue. So this generates some
output which is not expected by test-harness.js based tests.

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(right):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:21: if
(eventCount == 2) {
On 2016/04/13 13:05:00, Mounir Lamouri wrote:
> I think this will allow you to save some indentation:
> ```
> if (eventCount != 2)
>   return;
> ```

Acknowledged.

[Srirama, 2016-04-13 13:23:24]

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(left):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:22:
testExpected("textTrackDisplayElement(video, 'display').innerText", "");
On 2016/04/13 13:10:03, Srirama wrote:
> On 2016/04/13 13:05:00, Mounir Lamouri wrote:
> > On 2016/04/13 at 12:37:12, Srirama wrote:
> > > Removed this intentionally, because this is throwing error which is
printed
> in
> > the output.
> > 
> > Could you be more specific?
> 
> When we call "textTrackDisplayElement(video, 'display')" it throws 
> "No text track cue with display id '-webkit-media-text-track-display' is
> currently visible" error as there is no active cue. So this generates some
> output which is not expected by test-harness.js based tests.

My intention in removing it is that the activeCues.length check above is
sufficient.

[Srirama, 2016-04-13 13:34:30]

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html
(right):

https://codereview.chromium.org/1879353002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html:21: if
(eventCount == 2) {
On 2016/04/13 13:10:03, Srirama wrote:
> On 2016/04/13 13:05:00, Mounir Lamouri wrote:
> > I think this will allow you to save some indentation:
> > ```
> > if (eventCount != 2)
> >   return;
> > ```
> 
> Acknowledged.

Done.

[mlamouri (slow - plz ping), 2016-04-19 15:10:20]

lgtm

https://codereview.chromium.org/1879353002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-cue-mutable-fragment.html
(right):

https://codereview.chromium.org/1879353002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cue-mutable-fragment.html:55:
assert_false(testCue.getCueAsHTML() == testCue.getCueAsHTML());
assert_not_equals() ?

[Srirama, 2016-04-19 16:37:19]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-04-19 16:37:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1879353002/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-04-19 16:37:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879353002/60001

[commit-bot: I haz the power, 2016-04-19 17:48:20]

Description was changed from

==========
Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-04-19 17:48:21]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:13:32]

Description was changed from

==========
Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert track tests from video-test.js to testharness.js based

Cleaning up track-cue-inline*, track-cue-mutable* and track-cue-negative*
tests in media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/00fa6c72b82de81ab3b1cd68e9f4248eeac6b239
Cr-Commit-Position: refs/heads/master@{#388238}
==========

[commit-bot: I haz the power, 2016-04-22 19:13:34]

Patchset 3 (id:??) landed as
https://crrev.com/00fa6c72b82de81ab3b1cd68e9f4248eeac6b239
Cr-Commit-Position: refs/heads/master@{#388238}