third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html - Issue 1879353002: Convert track tests from video-test.js to testharness.js based

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html

Issue 1879353002: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-mutable-fragment-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Test that cue text is mutable.</title>

3 <head>	3 <script src="../media-file.js"></script>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <script src="../media-controls.js"></script>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <video>

	8 <track src="captions-webvtt/captions-gaps.vtt" kind="captions" default >

	9 </video>

	10 <script>

	11 async_test(function(t) {

	12 var video = document.querySelector("video");

	13 var testTrack = document.querySelector("track");

5	14

6 <script src=../media-file.js></script>	15 video.oncanplaythrough = t.step_func(testMutability);

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	16 testTrack.onload = t.step_func(testMutability);

8 (Please avoid writing new tests using video-test.js) -->

9 <script src=../video-test.js></script>

10 <script src=../media-controls.js></script>

11	17

12 <script>	18 var eventCount = 0;

	19 function testMutability() {

	20 eventCount++;

	21 if (eventCount == 2) {
	mlamouri (slow - plz ping) 2016/04/13 13:05:00 I think this will allow you to save some indentati I think this will allow you to save some indentation: ``` if (eventCount != 2) return; ``` Srirama 2016/04/13 13:10:03 Acknowledged. Show quoted text On 2016/04/13 13:05:00, Mounir Lamouri wrote: > I think this will allow you to save some indentation: > ``` > if (eventCount != 2) > return; > ``` Acknowledged. Srirama 2016/04/13 13:34:30 Done. Show quoted text On 2016/04/13 13:10:03, Srirama wrote: > On 2016/04/13 13:05:00, Mounir Lamouri wrote: > > I think this will allow you to save some indentation: > > ``` > > if (eventCount != 2) > > return; > > ``` > > Acknowledged. Done.
	22 // Test initial cue info.

	23 assert_equals(testTrack.track.activeCues.length, 0);

13	24

14 var testTrack;	25 assert_equals(testTrack.track.cues[0].startTime, 1.0);

15 var fragment;	26 assert_equals(testTrack.track.cues[1].startTime, 3.0);

16	27

17 function testMutability()	28 assert_equals(testTrack.track.cues[0].text, "Lorem ipsum dolor sit a met,");

18 {	29 var fragment = document.createDocumentFragment();

19 consoleWrite("<br>** Test initial cue info");	30 fragment.appendChild(document.createTextNode("Lorem ipsum dolor sit amet,"));

	31 assert_true(fragment.isEqualNode(testTrack.track.cues[0].getCueAsHTM L()));

20	32

21 testExpected("testTrack.track.activeCues.length", 0);	33 // Change the start time of cue #1, it should become visible.

22 testExpected("textTrackDisplayElement(video, 'display').innerText", "");	34 testTrack.track.cues[0].startTime = 0;
Srirama 2016/04/13 12:37:12 Removed this intentionally, because this is throwi Removed this intentionally, because this is throwing error which is printed in the output. mlamouri (slow - plz ping) 2016/04/13 13:05:00 Could you be more specific? Show quoted text On 2016/04/13 at 12:37:12, Srirama wrote: > Removed this intentionally, because this is throwing error which is printed in the output. Could you be more specific? Srirama 2016/04/13 13:10:03 When we call "textTrackDisplayElement(video, 'disp Show quoted text On 2016/04/13 13:05:00, Mounir Lamouri wrote: > On 2016/04/13 at 12:37:12, Srirama wrote: > > Removed this intentionally, because this is throwing error which is printed in > the output. > > Could you be more specific? When we call "textTrackDisplayElement(video, 'display')" it throws "No text track cue with display id '-webkit-media-text-track-display' is currently visible" error as there is no active cue. So this generates some output which is not expected by test-harness.js based tests. Srirama 2016/04/13 13:23:23 My intention in removing it is that the activeCues Show quoted text On 2016/04/13 13:10:03, Srirama wrote: > On 2016/04/13 13:05:00, Mounir Lamouri wrote: > > On 2016/04/13 at 12:37:12, Srirama wrote: > > > Removed this intentionally, because this is throwing error which is printed > in > > the output. > > > > Could you be more specific? > > When we call "textTrackDisplayElement(video, 'display')" it throws > "No text track cue with display id '-webkit-media-text-track-display' is > currently visible" error as there is no active cue. So this generates some > output which is not expected by test-harness.js based tests. My intention in removing it is that the activeCues.length check above is sufficient.
	35 assert_equals(testTrack.track.cues[0].startTime, 0);

	36 assert_equals(textTrackDisplayElement(video, "display").innerText, " Lorem ipsum dolor sit amet,");

23	37

24 testExpected("testTrack.track.cues[0].startTime", 1.0);	38 // Change the cue text, getCueAsHTML() should return a new, correct fragment.

25 testExpected("testTrack.track.cues[1].startTime", 3.0);	39 testTrack.track.cues[0].text = "Lorem <b>ipsum</b> <u>dolor</u> <i.s it>sit</i> amet,";

26	40 assert_equals(testTrack.track.cues[0].text, "Lorem <b>ipsum</b> <u>d olor</u> <i.sit>sit</i> amet,");

27 testExpected("testTrack.track.cues[0].text", "Lorem ipsum dolor sit amet,");

28 fragment = document.createDocumentFragment();

29 fragment.appendChild(document.createTextNode("Lorem ipsum dolor sit amet,"));

30 testExpected("fragment.isEqualNode(testTrack.track.cues[0].getCueAsH TML())", true);

31

32 consoleWrite("<br>** Change the start time of cue #1, it should beco me visible.");

33 run("testTrack.track.cues[0].startTime = 0");

34 testExpected("testTrack.track.cues[0].startTime", 0);

35 testExpected("textTrackDisplayElement(video, 'display').innerText", "Lorem ipsum dolor sit amet,");

36

37 consoleWrite("<br>** Change the cue text, getCueAsHTML() should retu rn a new, correct fragment.");

38 run("testTrack.track.cues[0].text = 'Lorem <b>ipsum</b> <u>dolor</u> <i.sit>sit</i> amet,'");

39 testExpected("testTrack.track.cues[0].text", "Lorem <b>ipsum</b> <u> dolor</u> <i.sit>sit</i> amet,");

40	41

41 fragment = document.createDocumentFragment();	42 fragment = document.createDocumentFragment();

42 fragment.appendChild(document.createTextNode("Lorem "));	43 fragment.appendChild(document.createTextNode("Lorem "));

43	44

44 var bold = document.createElement("b");	45 var bold = document.createElement("b");

45 bold.appendChild(document.createTextNode("ipsum"));	46 bold.appendChild(document.createTextNode("ipsum"));

46 fragment.appendChild(bold);	47 fragment.appendChild(bold);

47	48

48 fragment.appendChild(document.createTextNode(" "));	49 fragment.appendChild(document.createTextNode(" "));

49	50

50 var underline = document.createElement("u");	51 var underline = document.createElement("u");

51 underline.appendChild(document.createTextNode("dolor"));	52 underline.appendChild(document.createTextNode("dolor"));

52 fragment.appendChild(underline);	53 fragment.appendChild(underline);

53	54

54 fragment.appendChild(document.createTextNode(" "));	55 fragment.appendChild(document.createTextNode(" "));

55	56

56 var italics = document.createElement("i");	57 var italics = document.createElement("i");

57 italics.className = "sit";	58 italics.className = "sit";

58 italics.appendChild(document.createTextNode("sit"));	59 italics.appendChild(document.createTextNode("sit"));

59 fragment.appendChild(italics);	60 fragment.appendChild(italics);

60	61

61 fragment.appendChild(document.createTextNode(" amet,"));	62 fragment.appendChild(document.createTextNode(" amet,"));

62	63

63 testExpected("fragment.isEqualNode(testTrack.track.cues[0].getCueAsH TML())", true);	64 assert_true(fragment.isEqualNode(testTrack.track.cues[0].getCueAsHTM L()));

64	65

65 consoleWrite("");	66 t.done();

66 endTest();

67 }	67 }

	68 }

68	69

69 function loaded()	70 video.src = findMediaFile("video", "../content/counting");

70 {	71 });

71 findMediaElement();	72 </script>

72 testTrack = document.querySelector('track');

73

74 waitForEventsAndCall([[video, 'canplaythrough'], [testTrack, 'load'] ], testMutability);

75

76 video.src = findMediaFile('video', '../content/counting');

77 }

78

79 </script>

80 </head>

81 <body onload="loaded()">

82 <video controls >

83 <track src="captions-webvtt/captions-gaps.vtt" kind="captions" defau lt >

84 </video>

85 <p>Test that cue text is mutable.</p>

86 </body>

87 </html>

OLD	NEW