Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1879293002: Modify devtools to show passive event listeners. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Modify devtools to show passive event listeners. Add the ability to filter out what event listeners based on dispatch type; [All, Passive, Blocking]. Add the listing of passive in the event listener list similar to how useCapture is shown. BUG=601756 Review URL: https://codereview.chromium.org/1845493004 Cr-Commit-Position: refs/heads/master@{#386281} (cherry picked from commit ed3f93d1f6149e0861bd9df3dedabc84f2d28d33) Committed: https://chromium.googlesource.com/chromium/src/+/f8832dde5b6d2334386d584ac0b4fb765fa9e331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 8 chunks +29 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework-expected.txt View 5 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt View 1 chunk +19 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery1-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js View 9 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 3 chunks +39 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 3 chunks +20 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 3 chunks +17 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 chunk +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 8 months ago (2016-04-13 01:13:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8832dde5b6d2334386d584ac0b4fb765fa9e331.

Powered by Google App Engine
This is Rietveld 408576698