Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js

Issue 1879293002: Modify devtools to show passive event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js b/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js
index 17f30a7aaa028979f0f125f47184a0d55938d6e2..bd469c9d9bfc3d0de21e1e3f493e460190c7f887 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js
@@ -144,8 +144,10 @@ WebInspector.EventListenersView.prototype = {
/**
* @param {boolean} showFramework
+ * @param {boolean} showPassive
+ * @param {boolean} showBlocking
*/
- showFrameworkListeners: function(showFramework)
+ showFrameworkListeners: function(showFramework, showPassive, showBlocking)
{
var eventTypes = this._treeOutline.rootElement().children();
for (var eventType of eventTypes) {
@@ -157,6 +159,10 @@ WebInspector.EventListenersView.prototype = {
hidden = true;
if (listenerType === "frameworkInternal" && showFramework)
hidden = true;
+ if (!showPassive && listenerElement.eventListener().passive())
+ hidden = true;
+ if (!showBlocking && !listenerElement.eventListener().passive())
+ hidden = true;
listenerElement.hidden = hidden;
hiddenEventType = hiddenEventType && hidden;
}
@@ -267,6 +273,7 @@ WebInspector.ObjectEventListenerBar.prototype = {
var eventListener = this._eventListener;
var runtimeModel = eventListener.target().runtimeModel;
properties.push(runtimeModel.createRemotePropertyFromPrimitiveValue("useCapture", eventListener.useCapture()));
+ properties.push(runtimeModel.createRemotePropertyFromPrimitiveValue("passive", eventListener.passive()));
if (typeof eventListener.handler() !== "undefined")
properties.push(new WebInspector.RemoteObjectProperty("handler", eventListener.handler()));
WebInspector.ObjectPropertyTreeElement.populateWithProperties(this, properties, [], true, null);

Powered by Google App Engine
This is Rietveld 408576698