Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1879253003: No reason to prevent subpixel column heights in the initial height calculation. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No reason to prevent subpixel column heights in the initial height calculation. One test had to be updated, because Element.offsetHeight returns integers. The column height in the test went from 34 to 33.3333333ish with this code change, which is 33 if you ask offsetHeight. Committed: https://crrev.com/c1391da563dd9614e32ebec9599221b908b23b63 Cr-Commit-Position: refs/heads/master@{#387560}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
mstensho (USE GERRIT)
Levi had a very good point! :)
4 years, 8 months ago (2016-04-14 09:07:39 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-14 22:21:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879253003/1
4 years, 8 months ago (2016-04-14 22:21:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/50768) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-04-14 22:32:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879253003/1
4 years, 8 months ago (2016-04-15 06:13:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 08:11:35 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 08:14:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1391da563dd9614e32ebec9599221b908b23b63
Cr-Commit-Position: refs/heads/master@{#387560}

Powered by Google App Engine
This is Rietveld 408576698