third_party/WebKit/Source/core/layout/ColumnBalancer.h - Issue 1879253003: No reason to prevent subpixel column heights in the initial height calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.h

Issue 1879253003: No reason to prevent subpixel column heights in the initial height calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ColumnBalancer.h

diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.h b/third_party/WebKit/Source/core/layout/ColumnBalancer.h

index e559e05a4028d6c9e98489e128e02412e8cde9b6..a207a50532613f0ecec84d00bdc6d30cb2aa3a2d 100644

--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.h

+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.h

@@ -140,8 +140,7 @@ private:

// breaks assumed so far.

LayoutUnit columnLogicalHeight(LayoutUnit startOffset) const

{

- // TODO(leviw): This should probably be fromFloatCeil.

- return LayoutUnit(ceilf((m_breakOffset - startOffset) / float(m_assumedImplicitBreaks + 1)));

+ return LayoutUnit::fromFloatCeil(float(m_breakOffset - startOffset) / float(m_assumedImplicitBreaks + 1));

}

private:

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/newmulticol/balance6-expected.txt ('k') | no next file » | no next file with comments »