Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1878943008: Only eglTerminate command buffer displays when no displays are in use (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only eglTerminate command buffer displays when no displays are in use This is a workaround for crbug.com/603223 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1878943008 Committed: https://skia.googlesource.com/skia/+/3f21a2e9f3ea6e4f5ad8aca4bd260b4dba375732

Patch Set 1 #

Patch Set 2 : gc #

Patch Set 3 : rm extra newline #

Total comments: 4

Patch Set 4 : add statics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -10 lines) Patch
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 2 3 4 chunks +38 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bsalomon
4 years, 8 months ago (2016-04-13 19:58:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878943008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878943008/40001
4 years, 8 months ago (2016-04-13 20:48:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 21:01:24 UTC) #8
robertphillips
lgtm https://codereview.chromium.org/1878943008/diff/40001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (right): https://codereview.chromium.org/1878943008/diff/40001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp#newcode148 tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:148: static ? https://codereview.chromium.org/1878943008/diff/40001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp#newcode163 tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:163: static ?
4 years, 8 months ago (2016-04-13 21:24:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878943008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878943008/60001
4 years, 8 months ago (2016-04-13 21:43:40 UTC) #12
bsalomon
https://codereview.chromium.org/1878943008/diff/40001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (right): https://codereview.chromium.org/1878943008/diff/40001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp#newcode148 tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:148: On 2016/04/13 21:24:14, robertphillips wrote: > static ? Done. ...
4 years, 8 months ago (2016-04-13 21:43:41 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:04:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3f21a2e9f3ea6e4f5ad8aca4bd260b4dba375732

Powered by Google App Engine
This is Rietveld 408576698