Only eglTerminate command buffer displays when no displays are in use

tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp

 
 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
+#include "SkMutex.h"
 #include "SkOnce.h"
 #include "gl/GrGLInterface.h"
 #include "gl/GrGLAssembleInterface.h"
 #include "gl/command_buffer/GLTestContext_command_buffer.h"
 #include "../ports/SkOSEnvironment.h"
 #include "../ports/SkOSLibrary.h"
 
 #if defined SK_BUILD_FOR_MAC
 
 // EGL doesn't exist on the mac, so expose what we need to get the command buffer's EGL running.
@@ skipping 113 matching lines @@
 }
 
 static const GrGLInterface* create_command_buffer_interface() {
     load_command_buffer_once();
     if (!gfFunctionsLoadedSuccessfully) {
         return nullptr;
     }
     return GrGLAssembleGLESInterface(gLibrary, command_buffer_get_gl_proc);
 }
 
+// We use a poor man's garbage collector of EGLDisplays. They are only
+// terminated when there are no more EGLDisplays in use. See crbug.com/603223
+SK_DECLARE_STATIC_MUTEX(gDisplayMutex);
+static int gActiveDisplayCnt;
+SkTArray<EGLDisplay> gRetiredDisplays;
+

[robertphillips, 2016/04/13 21:24:14]

static ?

[bsalomon, 2016/04/13 21:43:40]

Done.

+EGLDisplay get_and_init_display() {
+    SkAutoMutexAcquire am(gDisplayMutex);
+    EGLDisplay dsp = gfGetDisplay(EGL_DEFAULT_DISPLAY);
+    if (dsp == EGL_NO_DISPLAY) {
+        return EGL_NO_DISPLAY;
+    }
+    EGLint major, minor;
+    if (!gfInitialize(dsp, &major, &minor)) {
+        gRetiredDisplays.push_back(dsp);
+        return EGL_NO_DISPLAY;
+    }
+    ++gActiveDisplayCnt;
+    return dsp;
+}
+

[robertphillips, 2016/04/13 21:24:14]

static ?

[bsalomon, 2016/04/13 21:43:40]

Done.

+void retire_display(EGLDisplay dsp) {
+    if (dsp == EGL_NO_DISPLAY) {
+        return;
+    }
+    SkAutoMutexAcquire am(gDisplayMutex);
+    gRetiredDisplays.push_back(dsp);
+    --gActiveDisplayCnt;
+    if (!gActiveDisplayCnt) {
+        for (EGLDisplay d : gRetiredDisplays) {
+            gfTerminate(d);
+        }
+        gRetiredDisplays.reset();
+    }
+}
 }  // anonymous namespace
 
 namespace sk_gpu_test {
 
 CommandBufferGLTestContext::CommandBufferGLTestContext()
     : fContext(EGL_NO_CONTEXT), fDisplay(EGL_NO_DISPLAY), fSurface(EGL_NO_SURFACE) {
 
     static const EGLint configAttribs[] = {
         EGL_SURFACE_TYPE, EGL_PBUFFER_BIT,
         EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
@@ skipping 37 matching lines @@
 void CommandBufferGLTestContext::initializeGLContext(void *nativeWindow, const int *configAttribs,
                                                  const int *surfaceAttribs) {
     load_command_buffer_once();
     if (!gfFunctionsLoadedSuccessfully) {
         SkDebugf("Command Buffer: Could not load EGL functions.\n");
         return;
     }
 
     // Make sure CHROMIUM_path_rendering is enabled for NVPR support.
     sk_setenv("CHROME_COMMAND_BUFFER_GLES2_ARGS", "--enable-gl-path-rendering");
-    fDisplay = gfGetDisplay(EGL_DEFAULT_DISPLAY);
+    fDisplay = get_and_init_display();
     if (EGL_NO_DISPLAY == fDisplay) {
         SkDebugf("Command Buffer: Could not create EGL display.\n");
         return;
     }
 
-    EGLint majorVersion;
-    EGLint minorVersion;
-    if (!gfInitialize(fDisplay, &majorVersion, &minorVersion)) {
-        SkDebugf("Command Buffer: Could not initialize EGL display.\n");
-        this->destroyGLContext();
-        return;
-    }
-
     EGLint numConfigs;
     if (!gfChooseConfig(fDisplay, configAttribs, static_cast<EGLConfig *>(&fConfig), 1,
                         &numConfigs) || numConfigs != 1) {
         SkDebugf("Command Buffer: Could not choose EGL config.\n");
         this->destroyGLContext();
         return;
     }
 
     if (nativeWindow) {
         fSurface = gfCreateWindowSurface(fDisplay,
@@ skipping 58 matching lines @@
         if (fContext) {
             gfDestroyContext(fDisplay, fContext);
             fContext = EGL_NO_CONTEXT;
         }
 
         if (fSurface) {
             gfDestroySurface(fDisplay, fSurface);
             fSurface = EGL_NO_SURFACE;
         }
 
-        gfTerminate(fDisplay);
+        retire_display(fDisplay);
         fDisplay = EGL_NO_DISPLAY;
     }
 }
 
 void CommandBufferGLTestContext::onPlatformMakeCurrent() const {
     if (!gfFunctionsLoadedSuccessfully) {
         return;
     }
     if (!gfMakeCurrent(fDisplay, fSurface, fSurface, fContext)) {
         SkDebugf("Command Buffer: Could not make EGL context current.\n");
@@ skipping 34 matching lines @@
     return result;
 }
 
 int CommandBufferGLTestContext::getSampleCount() {
     EGLint result = 0;
     gfGetConfigAttrib(fDisplay, static_cast<EGLConfig>(fConfig), EGL_SAMPLES, &result);
     return result;
 }
 
 }  // namespace sk_gpu_test