Revert of Makes MaterialDesignController initialization explicit

Revert of Makes MaterialDesignController initialization explicit (patchset #16 id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)] Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/11585#

Original issue's description:
> Makes MaterialDesignController initialization explicit
>
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
>
> BUG=595108
>
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595108
Committed: https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452
Cr-Commit-Position: refs/heads/master@{#386598}

[kjellander_chromium, 2016-04-12 06:18:01]

Created Revert of Makes MaterialDesignController initialization explicit

[commit-bot: I haz the power, 2016-04-12 06:18:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878943002/1

[commit-bot: I haz the power, 2016-04-12 06:18:57]

Description was changed from

==========
Revert of Makes MaterialDesignController initialization explicit (patchset #16
id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)]
Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct:
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...


Original issue's description:
> Makes MaterialDesignController initialization explicit
> 
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
> 
> BUG=595108
> 
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595108
==========

to

==========
Revert of Makes MaterialDesignController initialization explicit (patchset #16
id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)]
Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct:
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...


Original issue's description:
> Makes MaterialDesignController initialization explicit
> 
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
> 
> BUG=595108
> 
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595108
==========

[commit-bot: I haz the power, 2016-04-12 06:18:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-12 06:20:42]

Description was changed from

==========
Revert of Makes MaterialDesignController initialization explicit (patchset #16
id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)]
Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct:
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...


Original issue's description:
> Makes MaterialDesignController initialization explicit
> 
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
> 
> BUG=595108
> 
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595108
==========

to

==========
Revert of Makes MaterialDesignController initialization explicit (patchset #16
id:460001 of https://codereview.chromium.org/1845343005/ )

Reason for revert:
Breaks message_center_unittests on  Linux Chromium OS ASan LSan Tests (1):

NotifierSettingsViewTest.TestLearnMoreButton (run #1):
[ RUN      ] NotifierSettingsViewTest.TestLearnMoreButton
[7310:7310:0411/222127:19091916288:FATAL:material_design_controller.cc(63)]
Check failed: is_mode_initialized_.
#0 0x000000481ae1 __interceptor_backtrace
#1 0x0000006d28c3 base::debug::StackTrace::StackTrace()
#2 0x00000063f5ca logging::LogMessage::~LogMessage()
#3 0x0000008051c0 ui::MaterialDesignController::IsModeMaterial()
#4 0x000001e62411 ui::GetAuraColor()

The FindIt analysis seems correct:
https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.or...

Original issue's description:
> Makes MaterialDesignController initialization explicit
>
> Also delays updating Material Design specific colors in GTK UI until after
> about_flags::ConvertFlagsToSwitches() is called from
> ChromeBrowserMainParts::PreCreateThreadsImpl().
> Updates unit tests to avoid lazy initialization.
>
> BUG=595108
>
> Committed: https://crrev.com/147afe55fdc0f5b25d3b33090b2355ec67ce04b0
> Cr-Commit-Position: refs/heads/master@{#386582}

TBR=mkwst@chromium.org,estade@chromium.org,sky@chromium.org,thestig@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595108

Committed: https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452
Cr-Commit-Position: refs/heads/master@{#386598}
==========

[commit-bot: I haz the power, 2016-04-12 06:20:43]

Patchset 1 (id:??) landed as
https://crrev.com/14180847cb7f255fb5fbb4f790d1f01317ee5452
Cr-Commit-Position: refs/heads/master@{#386598}