MD Settings: allow subpages not wrapped in templates

MD Settings: allow subpages not wrapped in templates

BUG=597348
Committed: https://crrev.com/ba6071511cd380c8315d77c6dac28c8e52643616
Cr-Commit-Position: refs/heads/master@{#387599}

[michaelpg, 2016-04-11 17:52:09]

Description was changed from

==========
MD Settings: allow subpages not wrapped in templates

BUG=
==========

to

==========
MD Settings: allow subpages not wrapped in templates

BUG=597348
==========

[michaelpg, 2016-04-11 17:52:09]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-04-11 17:52:57]

dbeam: ptal. Nothing is broken yet but this lets us still
have sub-pages not wrapped in <template is="dom-if"> 
(something I do locally while developing sometimes).

[Dan Beam, 2016-04-11 17:55:15]

https://codereview.chromium.org/1878653002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1878653002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:130:
// Do nothing if the subpage doesn't exist or is already stamped.
don't we want to throw if we get to this code and it the routed page doesn't
exist?  it seems like this change might make it easier for programming errors to
happen, no?

[michaelpg, 2016-04-13 02:34:56]

https://codereview.chromium.org/1878653002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/1878653002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:130:
// Do nothing if the subpage doesn't exist or is already stamped.
On 2016/04/11 17:55:15, Dan Beam wrote:
> don't we want to throw if we get to this code and it the routed page doesn't
> exist?  it seems like this change might make it easier for programming errors
to
> happen, no?

I should clarify the comment. The subpage may be implemented as a
<neon-animatable> instead of a <template is="dom-if">, in which case we should
return early.

Obviously we don't do that anymore, but it's a valid state and something I run
into a lot when messing around locally trying to debug something. I don't think
this code should enforce that all subpages must be wrapped in <template>s.

[Dan Beam, 2016-04-14 03:20:22]

lgtm

[michaelpg, 2016-04-15 14:19:22]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-04-15 14:19:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1878653002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-04-15 14:19:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878653002/20001

[commit-bot: I haz the power, 2016-04-15 14:59:44]

Description was changed from

==========
MD Settings: allow subpages not wrapped in templates

BUG=597348
==========

to

==========
MD Settings: allow subpages not wrapped in templates

BUG=597348
==========

[commit-bot: I haz the power, 2016-04-15 14:59:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 15:00:54]

Description was changed from

==========
MD Settings: allow subpages not wrapped in templates

BUG=597348
==========

to

==========
MD Settings: allow subpages not wrapped in templates

BUG=597348

Committed: https://crrev.com/ba6071511cd380c8315d77c6dac28c8e52643616
Cr-Commit-Position: refs/heads/master@{#387599}
==========

[commit-bot: I haz the power, 2016-04-15 15:00:57]

Patchset 2 (id:??) landed as
https://crrev.com/ba6071511cd380c8315d77c6dac28c8e52643616
Cr-Commit-Position: refs/heads/master@{#387599}