Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 1878653002: MD Settings: allow subpages not wrapped in templates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
index 574350715c0b614aee8cf2211cb636011b3f8352..fc205a6d2b9f4b6e3ec3cee574cb6c0e5ea1408e 100644
--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
@@ -127,8 +127,9 @@ Polymer({
var template = Polymer.dom(this).querySelector(
'template[name="' + id + '"]');
- // Do nothing if the subpage is already stamped.
- if (template.if)
+ // Nothing to do if the subpage isn't wrapped in a <template> or the
+ // template is already stamped.
+ if (!template || template.if)
return;
// Set the subpage's id for use by neon-animated-pages.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698