Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1878563003: [wasm] Add test case for stack trace of wasm traps (Closed)

Created:
4 years, 8 months ago by Clemens Hammacher
Modified:
4 years, 8 months ago
Reviewers:
titzer, ahaas, JF
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@extend-wasm-stack-test-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add test case for stack trace of wasm traps Since traps now throw real Error objects, we get stack traces containing <WASM> functions on top-level. The additional tests check for two traps: unreachable and memory out-of-bounds. R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org BUG= Committed: https://crrev.com/e530556471efd889494c4aaec1687adee52b0579 Cr-Commit-Position: refs/heads/master@{#35691}

Patch Set 1 #

Patch Set 2 : update depends-on #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M test/mjsunit/wasm/stack.js View 1 2 3 chunks +50 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Clemens Hammacher
4 years, 8 months ago (2016-04-11 17:25:15 UTC) #1
titzer
lgtm
4 years, 8 months ago (2016-04-18 11:39:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878563003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878563003/40001
4 years, 8 months ago (2016-04-21 09:07:33 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 09:36:55 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:18 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e530556471efd889494c4aaec1687adee52b0579
Cr-Commit-Position: refs/heads/master@{#35691}

Powered by Google App Engine
This is Rietveld 408576698