[wasm] Also test structured stack trace

[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org

Committed: https://crrev.com/449af6f2295e0bfc7db751e32bfe42f7a3110179
Cr-Commit-Position: refs/heads/master@{#35687}

[JF, 2016-04-11 18:18:15]

Tests are sad.

https://codereview.chromium.org/1875153002/diff/1/test/mjsunit/wasm/stack.js
File test/mjsunit/wasm/stack.js (right):

https://codereview.chromium.org/1875153002/diff/1/test/mjsunit/wasm/stack.js#...
test/mjsunit/wasm/stack.js:5: // Flags: --expose-wasm
Start the file with:
// clang-format off

I should have done it a while ago, it's a PITA to format the file and have to
change line / column in the expected backtrace.

[Clemens Hammacher, 2016-04-11 18:25:23]

On 2016/04/11 at 18:18:15, jfb wrote:
> Tests are sad.

should be better now.

>
https://codereview.chromium.org/1875153002/diff/1/test/mjsunit/wasm/stack.js#...
> test/mjsunit/wasm/stack.js:5: // Flags: --expose-wasm
> Start the file with:
> // clang-format off
> 
> I should have done it a while ago, it's a PITA to format the file and have to
change line / column in the expected backtrace.

How is this related to clang-format?

[JF, 2016-04-11 19:35:09]

>
https://codereview.chromium.org/1875153002/diff/1/test/mjsunit/wasm/stack.js#...
> > test/mjsunit/wasm/stack.js:5: // Flags: --expose-wasm
> > Start the file with:
> > // clang-format off
> > 
> > I should have done it a while ago, it's a PITA to format the file and have
to
> change line / column in the expected backtrace.
> 
> How is this related to clang-format?

I found the presubmit check on clang-format annoying because doing it forces you
to also change the expected output. When a new version of clang-format decides
that things are formatted differently than previously it's causing needless
churn.

https://codereview.chromium.org/1875153002/diff/20001/test/mjsunit/wasm/stack.js
File test/mjsunit/wasm/stack.js (right):

https://codereview.chromium.org/1875153002/diff/20001/test/mjsunit/wasm/stack...
test/mjsunit/wasm/stack.js:98: })();
I find that structure hard to read, IMO it would be better to have something
like:

  [
    // func name        line   file name          toString
    ["STACK",             54, "stack.js", "stack.js:54:11"],
    ["<WASM>",          null,       null,         "<WASM>"],
    ["testStackFrames",   87, "stack.js", "stack.js:87:18"],
    [null,                98, "stack.js",  "stack.js:98:3"],
  ].verifyContains(stack, ...);

[Clemens Hammacher, 2016-04-12 08:57:03]

https://codereview.chromium.org/1875153002/diff/20001/test/mjsunit/wasm/stack.js
File test/mjsunit/wasm/stack.js (right):

https://codereview.chromium.org/1875153002/diff/20001/test/mjsunit/wasm/stack...
test/mjsunit/wasm/stack.js:98: })();
On 2016/04/11 at 19:35:09, JF wrote:
> I find that structure hard to read, IMO it would be better to have something
like:
> 
>   [
>     // func name        line   file name          toString
>     ["STACK",             54, "stack.js", "stack.js:54:11"],
>     ["<WASM>",          null,       null,         "<WASM>"],
>     ["testStackFrames",   87, "stack.js", "stack.js:87:18"],
>     [null,                98, "stack.js",  "stack.js:98:3"],
>   ].verifyContains(stack, ...);

Sure, that's nicer. Changed it accordingly.

[JF, 2016-04-12 18:20:53]

lgtm

[titzer, 2016-04-18 16:25:53]

On 2016/04/12 18:20:53, JF wrote:
> lgtm

lgtm

[Clemens Hammacher, 2016-04-20 14:54:14]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:54:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875153002/60001

[commit-bot: I haz the power, 2016-04-20 15:19:24]

Committed patchset #4 (id:60001)

[Michael Achenbach, 2016-04-20 16:23:00]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1903293002/ by machenbach@chromium.org.

The reason for reverting is: Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20s....

[Clemens Hammacher, 2016-04-21 08:18:40]

On 2016/04/20 at 16:23:00, machenbach wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1903293002/ by machenbach@chromium.org.
> 
> The reason for reverting is: Breaks:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20s....

This CL now also removes the line in mjsunit.status for ignoring test failures.
@machenbach, can I have your LGTM please? ;)

[Clemens Hammacher, 2016-04-21 08:19:09]

clemensh@chromium.org changed reviewers:
+ machenbach@chromium.org
- ahaas@chromium.org

[Michael Achenbach, 2016-04-21 08:28:50]

lgtm

[Clemens Hammacher, 2016-04-21 08:32:47]

Description was changed from

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org
==========

[Clemens Hammacher, 2016-04-21 08:33:16]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-04-21 08:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
jfb@chromium.org
Link to the patchset: https://codereview.chromium.org/1875153002/#ps80001
(title: "remove line from mjsunit.status")

[commit-bot: I haz the power, 2016-04-21 08:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875153002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875153002/80001

[commit-bot: I haz the power, 2016-04-21 08:35:29]

Committed patchset #5 (id:80001)

[nodir1, 2016-04-22 18:44:26]

Description was changed from

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/782c204c80b56b1bae2e8e2a937b4e6258630d61
Cr-Commit-Position: refs/heads/master@{#35666}
==========

[nodir1, 2016-04-22 18:44:27]

Patchset 5 (id:??) landed as
https://crrev.com/782c204c80b56b1bae2e8e2a937b4e6258630d61
Cr-Commit-Position: refs/heads/master@{#35666}

[commit-bot: I haz the power, 2016-04-22 19:14:10]

Description was changed from

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/782c204c80b56b1bae2e8e2a937b4e6258630d61
Cr-Commit-Position: refs/heads/master@{#35666}
==========

to

==========
[wasm] Also test structured stack trace

This extends the wasm test case which only checks the "simple"
string-variant of the stack trace.
It checks the return values of the getFunctionName, getLineNumber,
getFileName and toString methods.

R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org

Committed: https://crrev.com/449af6f2295e0bfc7db751e32bfe42f7a3110179
Cr-Commit-Position: refs/heads/master@{#35687}
==========

[commit-bot: I haz the power, 2016-04-22 19:14:11]

Patchset 5 (id:??) landed as
https://crrev.com/449af6f2295e0bfc7db751e32bfe42f7a3110179
Cr-Commit-Position: refs/heads/master@{#35687}