Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1878523002: Add the missing text input state tracking code to RenderWidgetHostViewMac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a bug number to TODO. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A BrowserPluginGuest is the browser side of a browser <--> embedder 5 // A BrowserPluginGuest is the browser side of a browser <--> embedder
6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder 6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
7 // renderer side of browser <--> embedder renderer communication. 7 // renderer side of browser <--> embedder renderer communication.
8 // 8 //
9 // BrowserPluginGuest lives on the UI thread of the browser process. Any 9 // BrowserPluginGuest lives on the UI thread of the browser process. Any
10 // messages about the guest render process that the embedder might be interested 10 // messages about the guest render process that the embedder might be interested
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 gfx::Size last_seen_view_size_; 418 gfx::Size last_seen_view_size_;
419 419
420 bool is_in_destruction_; 420 bool is_in_destruction_;
421 421
422 // BrowserPluginGuest::Init can only be called once. This flag allows it to 422 // BrowserPluginGuest::Init can only be called once. This flag allows it to
423 // exit early if it's already been called. 423 // exit early if it's already been called.
424 bool initialized_; 424 bool initialized_;
425 425
426 // Text input type states. 426 // Text input type states.
427 // Using scoped_ptr to avoid including the header file: view_messages.h. 427 // Using scoped_ptr to avoid including the header file: view_messages.h.
428 // TODO(ekaramad): The text input state tracking is now done by the
429 // WebContentsImpl. We should remove this variable (crbug.com/602427).
428 std::unique_ptr<const TextInputState> last_text_input_state_; 430 std::unique_ptr<const TextInputState> last_text_input_state_;
429 431
430 // The is the routing ID for a swapped out RenderView for the guest 432 // The is the routing ID for a swapped out RenderView for the guest
431 // WebContents in the embedder's process. 433 // WebContents in the embedder's process.
432 int guest_proxy_routing_id_; 434 int guest_proxy_routing_id_;
433 // Last seen state of drag status update. 435 // Last seen state of drag status update.
434 blink::WebDragStatus last_drag_status_; 436 blink::WebDragStatus last_drag_status_;
435 // Whether or not our embedder has seen a SystemDragEnded() call. 437 // Whether or not our embedder has seen a SystemDragEnded() call.
436 bool seen_embedder_system_drag_ended_; 438 bool seen_embedder_system_drag_ended_;
437 // Whether or not our embedder has seen a DragSourceEndedAt() call. 439 // Whether or not our embedder has seen a DragSourceEndedAt() call.
(...skipping 11 matching lines...) Expand all
449 // Weak pointer used to ask GeolocationPermissionContext about geolocation 451 // Weak pointer used to ask GeolocationPermissionContext about geolocation
450 // permission. 452 // permission.
451 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_; 453 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
452 454
453 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest); 455 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
454 }; 456 };
455 457
456 } // namespace content 458 } // namespace content
457 459
458 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_ 460 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698