third_party/WebKit/Source/core/fileapi/FileReaderSync.h - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.h

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp ('k') | third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/FileReaderSync.h

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderSync.h b/third_party/WebKit/Source/core/fileapi/FileReaderSync.h

index 830c5cfcfb39c28165245c6747c8814827a01adc..72b131489ee14045944360e86f084519d13792ea 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderSync.h

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderSync.h

@@ -33,7 +33,6 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "platform/heap/Handle.h"

-#include "wtf/RefCounted.h"

#include "wtf/text/WTFString.h"

namespace blink {

@@ -52,7 +51,7 @@ public:

return new FileReaderSync();

}

- PassRefPtr<DOMArrayBuffer> readAsArrayBuffer(ExecutionContext*, Blob*, ExceptionState&);

+ DOMArrayBuffer* readAsArrayBuffer(ExecutionContext*, Blob*, ExceptionState&);

String readAsBinaryString(ExecutionContext*, Blob*, ExceptionState&);

String readAsText(ExecutionContext* executionContext, Blob* blob, ExceptionState& ec)

{