third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp - Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

Issue 1878463002: Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReaderSync.h ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp b/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

index e9a3ce7b7a1e84c4dbc73b8371e3cb42805efd41..cddaf321aeebc42b8c7a5c60d946389e09e13f47 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

@@ -36,7 +36,6 @@

#include "core/fileapi/Blob.h"

#include "core/fileapi/FileError.h"

#include "core/fileapi/FileReaderLoader.h"

-#include "wtf/PassRefPtr.h"

namespace blink {

@@ -44,7 +43,7 @@ FileReaderSync::FileReaderSync()

{

}

-PassRefPtr<DOMArrayBuffer> FileReaderSync::readAsArrayBuffer(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)

+DOMArrayBuffer* FileReaderSync::readAsArrayBuffer(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)

{

ASSERT(blob);