cc/trees/layer_tree_host_impl.cc - Issue 1878323002: cc: Scroll on main when possible incorrect hit testing hits scrollbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1878323002: cc: Scroll on main when possible incorrect hit testing hits scrollbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make sure the unit test fails without the patch Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_impl.cc

diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc

index 76a15060abc1b43be3334c9671fa1a23aedc7eb1..ce3b1584091f8cfc2c5293d40a35d7e178235a4f 100644

--- a/cc/trees/layer_tree_host_impl.cc

+++ b/cc/trees/layer_tree_host_impl.cc

@@ -2671,7 +2671,7 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollBegin(

if (layer_impl) {

LayerImpl* scroll_layer_impl =

- active_tree_->FindFirstScrollingLayerThatIsHitByPoint(

+ active_tree_->FindFirstScrollingLayerOrScrollbarLayerThatIsHitByPoint(

device_viewport_point);

if (scroll_layer_impl &&

!HasScrollAncestor(layer_impl, scroll_layer_impl)) {

« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »