net/quic/quic_stream_factory.cc - Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory.cc

Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SHP_3

Patch Set: fix cronet && SpdyNetworkTransactionUnittests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/ios/cronet_environment.cc ('K') | « net/quic/quic_network_transaction_unittest.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | net/spdy/spdy_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_stream_factory.cc

diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc

index dd194ca0ea920c7af3c6698f21b702648038c8af..06b2b2b3bc502f75132587230e1e3854cb318b72 100644

--- a/net/quic/quic_stream_factory.cc

+++ b/net/quic/quic_stream_factory.cc

@@ -1702,12 +1702,13 @@ void QuicStreamFactory::MaybeInitialize() {

return;

has_initialized_data_ = true;

- for (const std::pair<const HostPortPair, AlternativeServiceInfoVector>&

+ for (const std::pair<const url::SchemeHostPort, AlternativeServiceInfoVector>&

key_value : http_server_properties_->alternative_service_map()) {

+ HostPortPair host_port_pair(key_value.first.host(), key_value.first.port());

for (const AlternativeServiceInfo& alternative_service_info :

key_value.second) {

if (alternative_service_info.alternative_service.protocol == QUIC) {

- quic_supported_servers_at_startup_.insert(key_value.first);

+ quic_supported_servers_at_startup_.insert(host_port_pair);

break;

}