components/cronet/ios/cronet_environment.cc - Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/cronet_environment.cc

Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SHP_3

Patch Set: fix cronet && SpdyNetworkTransactionUnittests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/url_request_context_adapter.cc ('k') | net/http/bidirectional_stream.cc » ('j') | net/spdy/spdy_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/ios/cronet_environment.cc

diff --git a/components/cronet/ios/cronet_environment.cc b/components/cronet/ios/cronet_environment.cc

index 00c1fd513373ce48095c3d97b7831bbd594603a1..681fefebb361dd3b281f277856ea43104d9ada36 100644

--- a/components/cronet/ios/cronet_environment.cc

+++ b/components/cronet/ios/cronet_environment.cc

@@ -327,9 +327,10 @@ void CronetEnvironment::InitializeOnNetworkThread() {

for (const auto& quic_hint : quic_hints_) {

net::AlternativeService alternative_service(net::AlternateProtocol::QUIC,

"", quic_hint.port());

+ url::SchemeHostPort quic_hint_server("https", quic_hint.host(),

+ quic_hint.port());

Zhongyi Shi 2016/04/19 19:08:18 Fixing cronet. Since it's quic_server, scheme here

main_context_->http_server_properties()->SetAlternativeService(

- quic_hint, alternative_service, base::Time::Max());

+ quic_hint_server, alternative_service, base::Time::Max());

params.quic_host_whitelist.insert(quic_hint.host());

}