net/http/bidirectional_stream_unittest.cc - Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 1878143005: SHP 4: Change AlternativeServiceMap to use SchemeHostPort as the key. No change to Pref data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SHP_3

Patch Set: fix cronet && SpdyNetworkTransactionUnittests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/ios/cronet_environment.cc ('K') | « net/http/bidirectional_stream.cc ('k') | net/http/http_network_transaction.cc » ('j') | net/spdy/spdy_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/bidirectional_stream_unittest.cc

diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc

index 2500458838362e8d52639fbf6223c0cfd3557992..b8f3cd47965ea05c431af2e4321dc8bf939794f2 100644

--- a/net/http/bidirectional_stream_unittest.cc

+++ b/net/http/bidirectional_stream_unittest.cc

@@ -1337,6 +1337,7 @@ TEST_F(BidirectionalStreamTest, TestHonorAlternativeServiceHeader) {

};

HostPortPair host_port_pair("www.example.org", 443);

+ url::SchemeHostPort server("https", "www.example.org", 443);

SpdySessionKey key(host_port_pair, ProxyServer::Direct(),

PRIVACY_MODE_DISABLED);

session_deps_.parse_alternative_services = true;

@@ -1371,8 +1372,7 @@ TEST_F(BidirectionalStreamTest, TestHonorAlternativeServiceHeader) {

delegate->GetTotalReceivedBytes());

AlternativeServiceVector alternative_service_vector =

- http_session_->http_server_properties()->GetAlternativeServices(

- host_port_pair);

+ http_session_->http_server_properties()->GetAlternativeServices(server);

ASSERT_EQ(1u, alternative_service_vector.size());

EXPECT_EQ(AlternateProtocolFromNextProto(kProtoQUIC1SPDY3),

alternative_service_vector[0].protocol);