Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr

Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr

BUG=554298
R=treib@chromium.org

Committed: https://crrev.com/f624e47486f525e6d266b99f90bcb81ad8f57295
Cr-Commit-Position: refs/heads/master@{#386625}

[dcheng, 2016-04-12 04:30:21]

his is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[Marc Treib, 2016-04-12 08:17:19]

Yay! LGTM

I indeed spotted some IWYU things, but I agree the burden shouldn't fall on you
to fix those. Carry on! :)

https://codereview.chromium.org/1878143002/diff/1/chrome/browser/supervised_u...
File
chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
(right):

https://codereview.chromium.org/1878143002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc:5:
#include
"chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h"
Out of curiosity: Did some automatic include-ordering-tool put this include
first? AFAIK this isn't strictly required for _unittest.cc files (not that I
mind, just curious).

[dcheng, 2016-04-12 08:26:50]

https://codereview.chromium.org/1878143002/diff/1/chrome/browser/supervised_u...
File
chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
(right):

https://codereview.chromium.org/1878143002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc:5:
#include
"chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h"
On 2016/04/12 08:17:19, Marc Treib wrote:
> Out of curiosity: Did some automatic include-ordering-tool put this include
> first? AFAIK this isn't strictly required for _unittest.cc files (not that I
> mind, just curious).

I have a helper script to add headers that automatically sorts:
https://docs.google.com/spreadsheets/d/19zyXGmZzdn9muv8ldpfOrgPaiHsxL4OHyGcnK...

The heuristics aren't perfect, but it works well enough 90% of the time.

FWIW, I think this is actually mandated by Google style in
http://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes:
    In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test
the stuff in dir2/foo2.h, order your includes as follows:

[dcheng, 2016-04-12 08:26:56]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-12 08:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878143002/1

[commit-bot: I haz the power, 2016-04-12 08:33:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-12 08:34:40]

Description was changed from

==========
Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr

BUG=554298
R=treib@chromium.org
==========

to

==========
Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr

BUG=554298
R=treib@chromium.org

Committed: https://crrev.com/f624e47486f525e6d266b99f90bcb81ad8f57295
Cr-Commit-Position: refs/heads/master@{#386625}
==========

[commit-bot: I haz the power, 2016-04-12 08:34:41]

Patchset 1 (id:??) landed as
https://crrev.com/f624e47486f525e6d266b99f90bcb81ad8f57295
Cr-Commit-Position: refs/heads/master@{#386625}