chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h - Issue 1878143002: Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h

Issue 1878143002: Convert //chrome/browser/supervised_user from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc ('K') | « chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc ('k') | chrome/browser/supervised_user/legacy/supervised_user_refresh_token_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h

diff --git a/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h b/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h

index b97cfd6d5a418dd5d458107765f9827e111dbcef..5309dcca0e1964365dc816c944cfceacb1644004 100644

--- a/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h

+++ b/chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.h

@@ -5,10 +5,11 @@

#ifndef CHROME_BROWSER_SUPERVISED_USER_LEGACY_SUPERVISED_USER_PREF_MAPPING_SERVICE_H_

#define CHROME_BROWSER_SUPERVISED_USER_LEGACY_SUPERVISED_USER_PREF_MAPPING_SERVICE_H_

+#include <memory>

#include "base/callback.h"

#include "base/callback_list.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/supervised_user/supervised_users.h"

#include "components/keyed_service/core/keyed_service.h"

@@ -49,7 +50,7 @@ class SupervisedUserPrefMappingService : public KeyedService {

PrefService* prefs_;

SupervisedUserSharedSettingsService* shared_settings_;

- scoped_ptr<CallbackList::Subscription> subscription_;

+ std::unique_ptr<CallbackList::Subscription> subscription_;

std::string supervised_user_id_;

PrefChangeRegistrar pref_change_registrar_;

base::WeakPtrFactory<SupervisedUserPrefMappingService> weak_ptr_factory_;