Add unit test for providing empty list of detail items

third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
index 985006d73822f75664a1b59358fc9ea839d47800..b79392da285d5122a8055a27aa985fe8cc8817c6 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
@@ -76,6 +76,14 @@ TEST_F(PaymentRequestTest, ItemListRequired)
     EXPECT_EQ(V8TypeError, getExceptionState().code());
 }
 
+TEST_F(PaymentRequestTest, ItemListIsNotEmpty)
+{
+    PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), buildPaymentDetailsForTest(PaymentTestDetailNoItems), getExceptionState());

[please use gerrit instead, 2016/04/11 21:46:36]

I would prefer this to be:
-------------------------------------------------
PaymentDetails details;
details.setItems(HeapVector<PaymentItem>());

PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), details,
getExceptionState());
-------------------------------------------------
Then you don't need changes in PaymentDetailsTestHelper.cpp and
PaymentDetailsTestHelper.h.

[rwlbuis, 2016/04/12 01:19:16]

Good idea, done :)

+
+    EXPECT_TRUE(getExceptionState().hadException());
+    EXPECT_EQ(V8TypeError, getExceptionState().code());
+}
+
 TEST_F(PaymentRequestTest, AtLeastOnePaymentDetailsItemRequired)
 {
     PaymentDetails details;