Add unit test for providing empty list of detail items

third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/testing/DummyPageHolder.h"
@@ skipping 58 matching lines @@
 }
 
 TEST_F(PaymentRequestTest, ItemListRequired)
 {
     PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), PaymentDetails(), getExceptionState());
 
     EXPECT_TRUE(getExceptionState().hadException());
     EXPECT_EQ(V8TypeError, getExceptionState().code());
 }
 
+TEST_F(PaymentRequestTest, ItemListIsNotEmpty)
+{
+    PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), buildPaymentDetailsForTest(PaymentTestDetailNoItems), getExceptionState());

[please use gerrit instead, 2016/04/11 21:46:36]

I would prefer this to be:
-------------------------------------------------
PaymentDetails details;
details.setItems(HeapVector<PaymentItem>());

PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), details,
getExceptionState());
-------------------------------------------------
Then you don't need changes in PaymentDetailsTestHelper.cpp and
PaymentDetailsTestHelper.h.

[rwlbuis, 2016/04/12 01:19:16]

Good idea, done :)

+
+    EXPECT_TRUE(getExceptionState().hadException());
+    EXPECT_EQ(V8TypeError, getExceptionState().code());
+}
+
 TEST_F(PaymentRequestTest, AtLeastOnePaymentDetailsItemRequired)
 {
     PaymentDetails details;
     details.setShippingOptions(HeapVector<ShippingOption>(2, buildShippingOptionForTest()));
 
     PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), details, getExceptionState());
 
     EXPECT_TRUE(getExceptionState().hadException());
     EXPECT_EQ(V8TypeError, getExceptionState().code());
 }
@@ skipping 34 matching lines @@
 {
     PaymentRequest* request = PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), buildPaymentDetailsForTest(), getExceptionState());
     EXPECT_FALSE(getExceptionState().hadException());
 
     request->abort(getExceptionState());
     EXPECT_TRUE(getExceptionState().hadException());
 }
 
 } // namespace
 } // namespace blink