Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1877893002: Refactor git cl RietveldUpload and GerritUpload. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor git cl RietveldUpload and GerritUpload. No functionality changes. R=machenbach@chromium.org,andybons@chromium.org BUG=579160, 597638 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -359 lines) Patch
M git_cl.py View 8 chunks +362 lines, -359 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
tandrii(chromium)
PTAL as you can see, it changes no expectations, though of course, not every path ...
4 years, 8 months ago (2016-04-11 16:57:47 UTC) #1
Sergiy Byelozyorov
lgtm
4 years, 8 months ago (2016-04-11 17:29:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877893002/1
4 years, 8 months ago (2016-04-11 21:33:17 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 21:35:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299844

Powered by Google App Engine
This is Rietveld 408576698