Refactor CMDUpload further to avoid checks IsGerrit().

Refactor CMDUpload further to avoid checks IsGerrit().

R=sergiyb@chromium.org,andybons@chromium.org,machenbach@chromium.org
BUG=579160, 597638
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299855

[tandrii(chromium), 2016-04-11 17:42:02]

PTAL

again, just refactoring, no expectation changes.

[Sergiy Byelozyorov, 2016-04-11 18:50:04]

lgtm w/ comment

https://codereview.chromium.org/1875163002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1875163002/diff/1/git_cl.py#newcode1976
git_cl.py:1976: #TODO(tandrii): implement and close the corresponding bug.
please mention bug here crbug.com/XXXXXX

[Michael Achenbach, 2016-04-12 08:33:49]

lgtm

https://codereview.chromium.org/1875163002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1875163002/diff/20001/git_cl.py#newcode1511
git_cl.py:1511: """Best effort check that user is authenticated with coreview
server."""
nit: codereview

[tandrii(chromium), 2016-04-12 14:10:31]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-04-12 14:10:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergiyb@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1875163002/#ps40001
(title: "git co R25")

[commit-bot: I haz the power, 2016-04-12 14:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1875163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1875163002/40001

[commit-bot: I haz the power, 2016-04-12 14:13:09]

Description was changed from

==========
Refactor CMDUpload further to avoid checks IsGerrit().

R=sergiyb@chromium.org,andybons@chromium.org,machenbach@chromium.org
BUG=579160,597638
==========

to

==========
Refactor CMDUpload further to avoid checks IsGerrit().

R=sergiyb@chromium.org,andybons@chromium.org,machenbach@chromium.org
BUG=579160,597638

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299855
==========

[commit-bot: I haz the power, 2016-04-12 14:13:10]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299855

[tandrii(chromium), 2016-04-12 14:13:32]

https://codereview.chromium.org/1875163002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1875163002/diff/1/git_cl.py#newcode1976
git_cl.py:1976: #TODO(tandrii): implement and close the corresponding bug.
On 2016/04/11 18:50:04, Sergiy Byelozyorov wrote:
> please mention bug here crbug.com/XXXXXX

Done.

https://codereview.chromium.org/1875163002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1875163002/diff/20001/git_cl.py#newcode1511
git_cl.py:1511: """Best effort check that user is authenticated with coreview
server."""
On 2016/04/12 08:33:49, Michael Achenbach wrote:
> nit: codereview

Done.