Issue 1877813003: Use exact name lookup for static fields in mirrors.

Issue 1877813003: Use exact name lookup for static fields in mirrors. (Closed)

Created:
4 years, 8 months ago by rmacnak

Modified:
4 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/lib/mirrors/private_class_field_other.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A	tests/lib/mirrors/private_class_field_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

hausner

LGTM. As always, a comment describing what is being tested would be nice. Also, describing ...

4 years, 8 months ago (2016-04-12 15:33:01 UTC) #3

rmacnak

Added. The old code is correct but not robust. LookupXAllowPrivate happens to be equivalent to ...

4 years, 8 months ago (2016-04-12 18:11:35 UTC) #4

rmacnak

4 years, 8 months ago (2016-04-12 18:15:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
71676a1e5b3a73ea372c8f8f6f888b280bfc5074 (presubmit successful).