Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: runtime/lib/mirrors.cc

Issue 1877813003: Use exact name lookup for static fields in mirrors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 7a1194b6826969e8ae8fbdec4d8a0f12c86125c2..40efc283c9d7cdfd56d2e07404124c037fcff2d8 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -718,7 +718,7 @@ static RawInstance* InvokeClassGetter(const Class& klass,
const bool throw_nsm_if_absent) {
// Note static fields do not have implicit getters.
const Field& field =
- Field::Handle(klass.LookupStaticFieldAllowPrivate(getter_name));
+ Field::Handle(klass.LookupStaticField(getter_name));
if (field.IsNull() || field.IsUninitialized()) {
const String& internal_getter_name = String::Handle(
Field::GetterName(getter_name));
@@ -1571,7 +1571,7 @@ DEFINE_NATIVE_ENTRY(ClassMirror_invokeSetter, 4) {
// Check for real fields and user-defined setters.
const Field& field =
- Field::Handle(klass.LookupStaticFieldAllowPrivate(setter_name));
+ Field::Handle(klass.LookupStaticField(setter_name));
Function& setter = Function::Handle();
const String& internal_setter_name = String::Handle(
Field::SetterName(setter_name));
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698