Source/bindings/v8/CustomElementHelpers.h - Issue 18778002: Inherit EventTarget interface instead of duplicating its code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementHelpers.h

Issue 18778002: Inherit EventTarget interface instead of duplicating its code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix the regressions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/CodeGeneratorV8.pm ('K') | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/CustomElementHelpers.cpp » ('j') | Source/modules/webaudio/MediaStreamAudioDestinationNode.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/CustomElementHelpers.h

diff --git a/Source/bindings/v8/CustomElementHelpers.h b/Source/bindings/v8/CustomElementHelpers.h

index 035d59c0d88cada9b909a507b43b447bbd1375a0..b6d11cb7908a7c7dfbedd24a755270e3fd704c30 100644

--- a/Source/bindings/v8/CustomElementHelpers.h

+++ b/Source/bindings/v8/CustomElementHelpers.h

@@ -31,6 +31,7 @@

#ifndef CustomElementHelpers_h

#define CustomElementHelpers_h

+#include "V8Element.h"

#include "bindings/v8/DOMDataStore.h"

#include "core/dom/Element.h"

#include "wtf/PassRefPtr.h"

@@ -76,7 +77,7 @@ private:

inline v8::Handle<v8::Object> CustomElementHelpers::wrap(Element* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate, const CreateWrapperFunction& createWrapper)

{

ASSERT(impl);

- ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());

+ ASSERT(DOMDataStore::getWrapper<V8Element>(impl, isolate).IsEmpty());

return CustomElementHelpers::createWrapper(impl, creationContext, isolate, createWrapper);

}