Source/bindings/v8/CustomElementHelpers.cpp - Issue 18778002: Inherit EventTarget interface instead of duplicating its code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementHelpers.cpp

Issue 18778002: Inherit EventTarget interface instead of duplicating its code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix the regressions Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/CustomElementHelpers.cpp

diff --git a/Source/bindings/v8/CustomElementHelpers.cpp b/Source/bindings/v8/CustomElementHelpers.cpp

index b369fb271b890009b104727207c670ed3f79c04e..3f3b68a518c31ccd020f4a50f31e9698ea13c1d3 100644

--- a/Source/bindings/v8/CustomElementHelpers.cpp

+++ b/Source/bindings/v8/CustomElementHelpers.cpp

@@ -69,7 +69,7 @@ v8::Handle<v8::Object> CustomElementHelpers::createWrapper(PassRefPtr<Element> i

wrapper->SetPrototype(customElementBinding->prototype());

- V8DOMWrapper::associateObjectWithWrapper(impl, customElementBinding->wrapperType(), wrapper, isolate, WrapperConfiguration::Dependent);

+ V8DOMWrapper::associateObjectWithWrapper<V8Element>(impl, customElementBinding->wrapperType(), wrapper, isolate, WrapperConfiguration::Dependent);

return wrapper;

}