Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: Source/core/dom/DocumentLifecycleObserver.h

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined~ Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/DocumentLifecycleObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DocumentLifecycleObserver.h
diff --git a/Source/core/dom/DocumentLifecycleObserver.h b/Source/core/dom/DocumentLifecycleObserver.h
index 47a449fc4f598388c8c30cccb0c8b448d4990103..dd7d521fb50bf4aa93e969f9cd05d529ed35c840 100644
--- a/Source/core/dom/DocumentLifecycleObserver.h
+++ b/Source/core/dom/DocumentLifecycleObserver.h
@@ -44,15 +44,15 @@ public:
virtual void documentWasDisposed() { }
};
-class DocumentLifecycleNotifier : public ContextLifecycleNotifier {
+class DocumentLifecycleNotifier : public ContextLifecycleNotifier {
public:
static PassOwnPtr<DocumentLifecycleNotifier> create(ScriptExecutionContext*);
void notifyDocumentWasDetached();
void notifyDocumentWasDisposed();
- virtual void addObserver(ContextLifecycleObserver*, ContextLifecycleObserver::Type as) OVERRIDE;
- virtual void removeObserver(ContextLifecycleObserver*, ContextLifecycleObserver::Type as) OVERRIDE;
+ virtual void addObserver(LifecycleObserver*, LifecycleObserver::Type) OVERRIDE;
+ virtual void removeObserver(LifecycleObserver*, LifecycleObserver::Type) OVERRIDE;
private:
explicit DocumentLifecycleNotifier(ScriptExecutionContext*);
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/DocumentLifecycleObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698