Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: Source/core/dom/DocumentLifecycleObserver.cpp

Issue 18777003: Extract simpler classes for observing context lifecycle and observe Page lifecycle inNavigatorVibra… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined~ Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/DocumentLifecycleObserver.h ('k') | Source/core/dom/ScriptExecutionContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DocumentLifecycleObserver.cpp
diff --git a/Source/core/dom/DocumentLifecycleObserver.cpp b/Source/core/dom/DocumentLifecycleObserver.cpp
index 2af13c08531a6aaa51c6395850974df2e5b2a747..ee456885bbce9691c6dde1452e44e26ff99d7a14 100644
--- a/Source/core/dom/DocumentLifecycleObserver.cpp
+++ b/Source/core/dom/DocumentLifecycleObserver.cpp
@@ -46,24 +46,24 @@ DocumentLifecycleNotifier::DocumentLifecycleNotifier(ScriptExecutionContext* con
{
}
-void DocumentLifecycleNotifier::addObserver(ContextLifecycleObserver* observer, ContextLifecycleObserver::Type as)
+void DocumentLifecycleNotifier::addObserver(LifecycleObserver* observer, LifecycleObserver::Type type)
{
- if (as == ContextLifecycleObserver::DocumentLifecycleObserverType) {
+ if (type == LifecycleObserver::DocumentLifecycleObserverType) {
RELEASE_ASSERT(m_iterating != IteratingOverDocumentObservers);
m_documentObservers.add(static_cast<DocumentLifecycleObserver*>(observer));
}
- ContextLifecycleNotifier::addObserver(observer, as);
+ ContextLifecycleNotifier::addObserver(observer, type);
}
-void DocumentLifecycleNotifier::removeObserver(ContextLifecycleObserver* observer, ContextLifecycleObserver::Type as)
+void DocumentLifecycleNotifier::removeObserver(LifecycleObserver* observer, LifecycleObserver::Type type)
{
- if (as == ContextLifecycleObserver::DocumentLifecycleObserverType) {
+ if (type == LifecycleObserver::DocumentLifecycleObserverType) {
RELEASE_ASSERT(m_iterating != IteratingOverDocumentObservers);
m_documentObservers.remove(static_cast<DocumentLifecycleObserver*>(observer));
}
- ContextLifecycleNotifier::removeObserver(observer, as);
+ ContextLifecycleNotifier::removeObserver(observer, type);
}
} // namespace WebCore
« no previous file with comments | « Source/core/dom/DocumentLifecycleObserver.h ('k') | Source/core/dom/ScriptExecutionContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698