Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1877453003: Only try to compute running_all_jobs time if we know when try-job verifier started (Closed)

Created:
4 years, 8 months ago by Sergiy Byelozyorov
Modified:
4 years, 8 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Only try to compute running_all_jobs time if we know when try-job verifier started R=agable@chromium.org BUG=601899 Committed: https://chromium.googlesource.com/infra/infra/+/f5967cbaf89645a9576cfcbdb5867f1c717895d0

Patch Set 1 #

Patch Set 2 : Added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -36 lines) Patch
M appengine/chromium_cq_status/handlers/patch_summary.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/chromium_cq_status/handlers/test/patch_summary_test.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + appengine/chromium_cq_status/handlers/test/patch_summary_test.expected/PatchSummaryTest.test_no_verifier_start.json View 1 1 chunk +45 lines, -35 lines 0 comments Download
A appengine/chromium_cq_status/handlers/test/resources/patch_no_verifier_start.json View 1 1 chunk +164 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergiy Byelozyorov
4 years, 8 months ago (2016-04-08 20:29:49 UTC) #1
agable
LGTM, this will fix the immediate error. But why did this error start showing up? ...
4 years, 8 months ago (2016-04-08 20:31:48 UTC) #2
Sergiy Byelozyorov
On 2016/04/08 20:31:48, agable wrote: > LGTM, this will fix the immediate error. > > ...
4 years, 8 months ago (2016-04-08 20:44:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877453003/20001
4 years, 8 months ago (2016-04-08 20:47:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 20:51:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/f5967cbaf89645a9576cfcbdb5867...

Powered by Google App Engine
This is Rietveld 408576698