appengine/chromium_cq_status/handlers/patch_summary.py - Issue 1877453003: Only try to compute running_all_jobs time if we know when try-job verifier started

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/chromium_cq_status/handlers/patch_summary.py

Issue 1877453003: Only try to compute running_all_jobs time if we know when try-job verifier started (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Added tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/chromium_cq_status/handlers/patch_summary.py

diff --git a/appengine/chromium_cq_status/handlers/patch_summary.py b/appengine/chromium_cq_status/handlers/patch_summary.py

index 6538db0630638ec3fdc6f82051d5ce2dd298e843..f2bcbcebf7777424feb080ae9e346c2c06db8a2b 100644

--- a/appengine/chromium_cq_status/handlers/patch_summary.py

+++ b/appengine/chromium_cq_status/handlers/patch_summary.py

@@ -101,7 +101,8 @@ def summarize_attempt(raw_attempt, now):

verifier_start_timestamp = timestamp

elif action == 'verifier_jobs_update':

job_tracker.update_jobs(record)

- elif action in ('verifier_pass', 'verifier_fail'):

+ elif (action in ('verifier_pass', 'verifier_fail') and

+ verifier_start_timestamp is not None):

durations['running_all_jobs'] = timestamp - verifier_start_timestamp

verifier_start_timestamp = None

« no previous file with comments | « no previous file | appengine/chromium_cq_status/handlers/test/patch_summary_test.py » ('j') | no next file with comments »