Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1877283002: ServiceWorker: Remove unused MessageEvent implementation from ServiceWorkerGlobalScope (Closed)

Created:
4 years, 8 months ago by nhiroki
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, falken, haraken, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove unused MessageEvent implementation from ServiceWorkerGlobalScope This is a follow-up patch for issue 598608. After ExtendableMessageEvent is shipped, MessageEvent on ServiceWorkerGlobalScope is no longer used. This patch removes implementation and UMA for the event and adds a new UMA for ExtendableMessageEvent instead. BUG=570820, 602924 Committed: https://crrev.com/9fc9575ca4928dcca5d6ca5b8c36ffe87466ab46 Cr-Commit-Position: refs/heads/master@{#388136}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -210 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +0 lines, -53 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 2 chunks +0 lines, -17 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 4 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
nhiroki
PTAL, thanks!
4 years, 8 months ago (2016-04-14 04:36:09 UTC) #7
falken
lgtm, great
4 years, 8 months ago (2016-04-14 17:32:27 UTC) #8
nhiroki
+mkwst@, can you review following files? * content/common/service_worker/service_worker_messages.h * third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in * third_party/WebKit/Source/web/* * third_party/WebKit/public/web/WebRuntimeFeatures.h +isherman@, ...
4 years, 8 months ago (2016-04-15 00:37:12 UTC) #10
Ilya Sherman
histograms lgtm
4 years, 8 months ago (2016-04-15 00:57:55 UTC) #11
Mike West
LGTM
4 years, 8 months ago (2016-04-18 20:36:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877283002/60001
4 years, 8 months ago (2016-04-19 00:52:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-04-19 04:43:14 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 04:44:59 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9fc9575ca4928dcca5d6ca5b8c36ffe87466ab46
Cr-Commit-Position: refs/heads/master@{#388136}

Powered by Google App Engine
This is Rietveld 408576698