content/browser/service_worker/service_worker_metrics.cc - Issue 1877283002: ServiceWorker: Remove unused MessageEvent implementation from ServiceWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1877283002: ServiceWorker: Remove unused MessageEvent implementation from ServiceWorkerGlobalScope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.cc

diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc

index 3fdb74f56515867815144b692997b471660a0fe7..668b64f8698d3e90058415489e296f1bf4d1641e 100644

--- a/content/browser/service_worker/service_worker_metrics.cc

+++ b/content/browser/service_worker/service_worker_metrics.cc

@@ -324,8 +324,8 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,

UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PushEvent.Time", time);

break;

case EventType::MESSAGE:

- // TODO(nhiroki): Record event duration for Message event after

- // ExtendableMessageEvent is enabled by default (crbug.com/543198).

+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.ExtendableMessageEvent.Time",

+ time);

break;

// For now event duration for these events is not recorded.