[Media Router Tests] Add tests for MediaRouterFactory.

chrome/browser/media/router/media_router_factory.h

Index: chrome/browser/media/router/media_router_factory.h
diff --git a/chrome/browser/media/router/media_router_factory.h b/chrome/browser/media/router/media_router_factory.h
index 4bfac5613b9f5f1e538519ecc42856266d840d97..0804ac987712f312d2b7b7fe56b2420e943fd06c 100644
--- a/chrome/browser/media/router/media_router_factory.h
+++ b/chrome/browser/media/router/media_router_factory.h
@@ -5,6 +5,7 @@
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_FACTORY_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_FACTORY_H_
 
+#include "base/gtest_prod_util.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
@@ -30,10 +31,15 @@ class MediaRouterFactory : public BrowserContextKeyedServiceFactory {
 
  private:
   friend struct base::DefaultLazyInstanceTraits<MediaRouterFactory>;
+  FRIEND_TEST_ALL_PREFIXES(MediaRouterFactoryTest,

[mark a. foltz, 2016/04/12 17:21:23]

Can be removed if the static fn below is also removed.

[imcheng, 2016/04/12 17:56:33]

Acknowledged.

+                           OffTheRecordBrowserContextShutdown);
 
   MediaRouterFactory();
   ~MediaRouterFactory() override;
 
+  // Exposed for testing.
+  static MediaRouterFactory* GetMediaRouterFactory();

[mark a. foltz, 2016/04/12 17:21:23]

Is this necessary or can you just new up a MediaRouterFactory in your test?

[imcheng, 2016/04/12 17:56:33]

It's possible to new a MediaRouterFactory, but I will not be able to use it to
create a MediaRouter instance with the current set of public APIs. The only way
is to use the public static method which uses the singleton instance of the
factory.

[mark a. foltz, 2016/04/22 21:17:55]

OK.  Please name it GetMediaRouterFactoryForTest() to make it clear it's not the
correct API for usage.

[imcheng, 2016/04/26 07:02:37]

Done.

+
   // BrowserContextKeyedServiceFactory interface.
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;