[Media Router Tests] Add tests for MediaRouterFactory.

chrome/browser/media/router/media_router_factory.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_FACTORY_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_FACTORY_H_
 
+#include "base/gtest_prod_util.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace media_router {
 
 class MediaRouter;
 
 // A factory that lazily returns a MediaRouter implementation for a given
 // BrowserContext.
 class MediaRouterFactory : public BrowserContextKeyedServiceFactory {
  public:
   static MediaRouter* GetApiForBrowserContext(content::BrowserContext* context);
 
  protected:
   // We override the shutdown method for the factory to give the Media Router a
   // chance to remove off the record media routes.
   void BrowserContextShutdown(content::BrowserContext* context) override;
 
  private:
   friend struct base::DefaultLazyInstanceTraits<MediaRouterFactory>;
+  FRIEND_TEST_ALL_PREFIXES(MediaRouterFactoryTest,

[mark a. foltz, 2016/04/12 17:21:23]

Can be removed if the static fn below is also removed.

[imcheng, 2016/04/12 17:56:33]

Acknowledged.

+                           OffTheRecordBrowserContextShutdown);
 
   MediaRouterFactory();
   ~MediaRouterFactory() override;
 
+  // Exposed for testing.
+  static MediaRouterFactory* GetMediaRouterFactory();

[mark a. foltz, 2016/04/12 17:21:23]

Is this necessary or can you just new up a MediaRouterFactory in your test?

[imcheng, 2016/04/12 17:56:33]

It's possible to new a MediaRouterFactory, but I will not be able to use it to
create a MediaRouter instance with the current set of public APIs. The only way
is to use the public static method which uses the singleton instance of the
factory.

[mark a. foltz, 2016/04/22 21:17:55]

OK.  Please name it GetMediaRouterFactoryForTest() to make it clear it's not the
correct API for usage.

[imcheng, 2016/04/26 07:02:37]

Done.

+
   // BrowserContextKeyedServiceFactory interface.
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;
 
   KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* context) const override;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterFactory);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_FACTORY_H_