Rehash and clear deleted entries in weak collections during GC

Rehash and clear deleted entries in weak collections during GC

Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.

BUG=v8:4909
R=hpayer@chromium.org
LOG=n

Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d
Cr-Commit-Position: refs/heads/master@{#35514}

[jochen (gone - plz use gerrit), 2016-04-14 10:40:29]

all green :)

ptal

[Hannes Payer (out of office), 2016-04-14 10:42:39]

Can you add a regression test?

LGTM with one nit

https://codereview.chromium.org/1877233005/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1877233005/diff/60001/src/objects.cc#newcode1...
src/objects.cc:16880: if (HashTable::ComputeCapacity(nof * 2) >
HashTable::kMaxCapacity) {
Compute nof * 2 before in a local variable an use it also below in 16888 to stay
in sync.

[jochen (gone - plz use gerrit), 2016-04-14 20:52:41]

Description was changed from

==========
When we can't grow a table, try a last resort GC

For weak collections, this might actually keep us from crashing, and for
other use cases, at least it won't hurt

BUG=v8:4909
R=hpayer@chromium.org
LOG=n
==========

to

==========
Rehash and clear deleted entries in weak collections during GC

Otherwise, they'll just keep growing until we run out of memory or hit the
FixedArray's maximum capacity.

BUG=v8:4909
R=hpayer@chromium.org
LOG=n
==========

[jochen (gone - plz use gerrit), 2016-04-14 20:53:03]

after some digging, here's a better fix - actually free memory from weak
collections :)

[Hannes Payer (out of office), 2016-04-15 08:20:12]

LGTM, one nit

https://codereview.chromium.org/1877233005/diff/100001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1877233005/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.cc:2554: if ((table->NumberOfDeletedElements() << 1) >
table->NumberOfElements()) {
Can you make that a constant?

[jochen (gone - plz use gerrit), 2016-04-15 08:21:28]

https://codereview.chromium.org/1877233005/diff/100001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1877233005/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.cc:2554: if ((table->NumberOfDeletedElements() << 1) >
table->NumberOfElements()) {
On 2016/04/15 at 08:20:11, Hannes Payer wrote:
> Can you make that a constant?

which one do you propose?

[jochen (gone - plz use gerrit), 2016-04-15 09:39:14]

made it a constant. ptal.

[jochen (gone - plz use gerrit), 2016-04-15 09:57:20]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-15 09:57:20]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1877233005/#ps140001
(title: "updates")

[commit-bot: I haz the power, 2016-04-15 09:57:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1877233005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1877233005/140001

[commit-bot: I haz the power, 2016-04-15 10:21:16]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-15 10:21:50]

Description was changed from

==========
Rehash and clear deleted entries in weak collections during GC

Otherwise, they'll just keep growing until we run out of memory or hit the
FixedArray's maximum capacity.

BUG=v8:4909
R=hpayer@chromium.org
LOG=n
==========

to

==========
Rehash and clear deleted entries in weak collections during GC

Otherwise, they'll just keep growing until we run out of memory or hit the
FixedArray's maximum capacity.

BUG=v8:4909
R=hpayer@chromium.org
LOG=n

Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d
Cr-Commit-Position: refs/heads/master@{#35514}
==========

[commit-bot: I haz the power, 2016-04-15 10:21:51]

Patchset 8 (id:??) landed as
https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d
Cr-Commit-Position: refs/heads/master@{#35514}

[Michael Achenbach, 2016-04-15 12:15:38]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1891863003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert. Suspect for gc stress
crashes, like:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20....