tools/mb/mb_unittest.py - Issue 1877173002: Change how MB handles goma_dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb_unittest.py

Issue 1877173002: Change how MB handles goma_dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/mb_unittest.py

diff --git a/tools/mb/mb_unittest.py b/tools/mb/mb_unittest.py

index dbb093d3898661a5c130f01cb16e2347e182530f..1a600d8d3c6242c8efff1a3246fb1a43c16d6913 100755

--- a/tools/mb/mb_unittest.py

+++ b/tools/mb/mb_unittest.py

@@ -131,8 +131,8 @@ TEST_CONFIG = """\

'gyp': {'type': 'gyp'},

'gn': {'type': 'gn'},

'goma': {

- 'gn_args': 'use_goma=true goma_dir="$(goma_dir)"',

- 'gyp_defines': 'goma=1 gomadir=$(goma_dir)',

+ 'gn_args': 'use_goma=true',

+ 'gyp_defines': 'goma=1',

'rel': {

'gn_args': 'is_debug=false',

« tools/mb/mb.py ('K') | « tools/mb/mb_config.pyl ('k') | no next file » | no next file with comments »