Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: tools/mb/mb_config.pyl

Issue 1877173002: Change how MB handles goma_dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/mb/mb.py ('K') | « tools/mb/mb.py ('k') | tools/mb/mb_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index e2cfe335e1f0b175aaf08638cc2e542e5bf8ef1e..9e1a41626639c2c0026bf7693dca1e9cfaa4a243 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -1688,8 +1688,8 @@
'goma': {
# The MB code will properly escape goma_dir if necessary in the GYP
# code path; the GN code path needs no escaping.
- 'gn_args': 'use_goma=true goma_dir="$(goma_dir)"',
- 'gyp_defines': 'use_goma=1 gomadir=$(goma_dir)',
+ 'gn_args': 'use_goma=true',
+ 'gyp_defines': 'use_goma=1',
},
'gpu_tests': {
« tools/mb/mb.py ('K') | « tools/mb/mb.py ('k') | tools/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698