chrome/browser/ui/views/toolbar/browser_actions_container.h - Issue 1877143002: Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.h

Issue 1877143002: Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/settings_api_bubble_helper_views.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/browser_actions_container.h

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.h b/chrome/browser/ui/views/toolbar/browser_actions_container.h

index fc29542ff684cdef3f65add3cde0100b4e550dd1..da220d2964acc1c3bc0a787b5da902dcab9683b4 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container.h

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.h

@@ -32,7 +32,7 @@ class Extension;

}

namespace views {

-class BubbleDelegateView;

+class BubbleDialogDelegateView;

class ResizeArea;

}

@@ -246,7 +246,7 @@ class BrowserActionsContainer : public views::View,

void OnWidgetClosing(views::Widget* widget) override;

void OnWidgetDestroying(views::Widget* widget) override;

- views::BubbleDelegateView* active_bubble() { return active_bubble_; }

+ views::BubbleDialogDelegateView* active_bubble() { return active_bubble_; }

ChevronMenuButton* chevron_for_testing() { return chevron_; }

@@ -328,7 +328,7 @@ class BrowserActionsContainer : public views::View,

std::unique_ptr<DropPosition> drop_position_;

// The extension bubble that is actively showing, if any.

- views::BubbleDelegateView* active_bubble_;

+ views::BubbleDialogDelegateView* active_bubble_;

DISALLOW_COPY_AND_ASSIGN(BrowserActionsContainer);

};