chrome/browser/ui/views/settings_api_bubble_helper_views.cc - Issue 1877143002: Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 1877143002: Convert ToolbarActionsBarBubbleViews to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

diff --git a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

index 14857891a2a02e614bda9b2d42bb81cfe2549f53..6bda4f619537e1fabdce62fc2ea5f6d890701f57 100644

--- a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

+++ b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

@@ -45,7 +45,7 @@ void ShowSettingsApiBubble(SettingsApiOverrideType type,

new ExtensionMessageBubbleBridge(

std::move(settings_api_bubble))));

bubble->set_arrow(arrow);

- views::BubbleDelegateView::CreateBubble(bubble);

+ views::BubbleDialogDelegateView::CreateBubble(bubble);

bubble->Show();

}

@@ -122,7 +122,7 @@ void MaybeShowExtensionControlledNewTabPage(

std::unique_ptr<ToolbarActionsBarBubbleDelegate>(

new ExtensionMessageBubbleBridge(std::move(ntp_overridden_bubble))));

bubble->set_arrow(views::BubbleBorder::TOP_RIGHT);

- views::BubbleDelegateView::CreateBubble(bubble);

+ views::BubbleDialogDelegateView::CreateBubble(bubble);

bubble->Show();

}